Rename query type to batch mode. #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoyla
requested review from
armfazh,
bhalleycf,
cjpatton,
fisherdarling,
cbranch,
lbaquerofierro,
mendess,
Noah-Kennedy and
RageKnify
as code owners
mendess
approved these changes
Nov 28, 2024
jhoyla
force-pushed
the
jhoyla/rename-query-type-to-batch-mode
branch
from
e22d84d to
6858ee2
Compare
mendess
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft 12 renames "query type" to "batch mode". This PR mirrors that change.
Doing so has lead to some changes in the naming of various structs.
QueryConfigVaris now simplyBatchMode, andDapQueryConfigis nowDapBatchMode.You can see from the conversion functions that this makes more sense.
We preserve the format of the
BatchModestructs from draft-09, rather than storing anopaque batch_config<1..2^16-1>, because it doesn't make sense to store unparsed/encoded data.