Make more use of DapRole enums #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendess
force-pushed
the
mendess/replace-is-leader-bool
branch
2 times, most recently
from
bcfeb62 to
596fc75
Compare
mendess
force-pushed
the
mendess/replace-is-leader-bool
branch
from
b12f3be to
4d064b8
Compare
mendess
force-pushed
the
mendess/replace-is-leader-bool
branch
from
4d064b8 to
5ef0e50
Compare
mendess
requested review from
armfazh,
bhalleycf,
cjpatton,
fisherdarling,
cbranch,
lbaquerofierro,
Noah-Kennedy,
RageKnify and
jhoyla
as code owners
armfazh
reviewed
Nov 27, 2024
mendess
force-pushed
the
mendess/replace-is-leader-bool
branch
from
5ef0e50 to
51b8b34
Compare
armfazh
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DapRole enum is underused and under featured, leading to code like
is_leader: boolwhere an instance of the enum would make calling code more readable (there are places wherefalse /* helper */can be see whereDapRole::Helperwould be much better)This PR also factors out the calculation of the
infoandaadparameters needed for hpke encryption and decryption. Making this part both more type safe and taking it out of higher level codeThis PR should be reviewed one commit at a time