Rename the try_put_agg_share_span() retry metric
#411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
armfazh,
bhalleycf,
captain-mota,
chris-wood and
mendess
as code owners
cjpatton
force-pushed
the
cjpatton/try-put-agg-share-span
branch
from
0c5e259 to
f109916
Compare
This was referenced Oct 16, 2023
cjpatton
force-pushed
the
cjpatton/try-put-agg-share-span
branch
from
f109916 to
d0ac903
Compare
cjpatton
changed the title
cjpatton
changed the title
try_put_agg_share_span() retry metric
mendess
approved these changes
Oct 24, 2023
In draft07 we commit the state change during the initial aggregation job request.
cjpatton
force-pushed
the
cjpatton/try-put-agg-share-span
branch
from
d0ac903 to
099fcad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #350.
In DAP-07 it won't be specific to
AggregationJobContinueReq.