Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move static labels to Registry to clean up Prometheus metrics. #410

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Move static labels to Registry to clean up Prometheus metrics. #410

merged 1 commit into from
Oct 18, 2023

Conversation

oliy
Copy link
Contributor

@oliy oliy commented Oct 13, 2023

No description provided.

cjpatton
cjpatton approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but looks good overall. May be worth validating in the Testing environment before deploying to Prod or Preprod.

mendess
mendess approved these changes Oct 16, 2023
View reviewed changes
daphne/src/roles/mod.rs Show resolved Hide resolved
@oliy oliy force-pushed the oli/simplify_metrics branch 2 times, most recently from 2f18313 to e458fd8 Compare October 16, 2023 15:09
@oliy oliy force-pushed the oli/simplify_metrics branch from e458fd8 to 55c87d4 Compare October 17, 2023 14:41
@mendess mendess merged commit 2fb4b88 into cloudflare:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendess mendess mendess approved these changes

@cjpatton cjpatton cjpatton approved these changes

@armfazh armfazh Awaiting requested review from armfazh armfazh is a code owner

@bhalleycf bhalleycf Awaiting requested review from bhalleycf bhalleycf is a code owner

@captain-mota captain-mota Awaiting requested review from captain-mota

@chris-wood chris-wood Awaiting requested review from chris-wood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliy @cjpatton @mendess