Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shard aggregate store in order to not reach durable object value size limits #407

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Shard aggregate store in order to not reach durable object value size limits #407

merged 1 commit into from
Oct 17, 2023

Conversation

mendess
Copy link
Collaborator

@mendess mendess commented Oct 12, 2023

No description provided.

@mendess mendess self-assigned this Oct 12, 2023
cjpatton
cjpatton reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is in the public repo, this can do with more code comments. For starters, I don't see any documentation about what limits we're working around.

@mendess mendess force-pushed the mendess/shard-aggregate-store branch 3 times, most recently from c152e15 to 780d38a Compare October 16, 2023 17:09
cjpatton
cjpatton reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the docucomment for the AggregateStore needs to be updated. In particular, the schema has changed, correct?

daphne_worker/src/durable/aggregate_store.rs Outdated Show resolved Hide resolved
@mendess mendess force-pushed the mendess/shard-aggregate-store branch from 780d38a to 848d6ef Compare October 16, 2023 17:20
@mendess mendess force-pushed the mendess/shard-aggregate-store branch from 848d6ef to 9cb6aa5 Compare October 16, 2023 17:33
cjpatton
cjpatton approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦆 - go ahead and merge once CI is happy.

@mendess mendess merged commit 422d3d0 into main Oct 17, 2023
@mendess mendess deleted the mendess/shard-aggregate-store branch October 17, 2023 11:07
@cjpatton cjpatton mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpatton cjpatton cjpatton approved these changes

@armfazh armfazh Awaiting requested review from armfazh armfazh is a code owner

@bhalleycf bhalleycf Awaiting requested review from bhalleycf bhalleycf is a code owner

@captain-mota captain-mota Awaiting requested review from captain-mota

@chris-wood chris-wood Awaiting requested review from chris-wood

Assignees

@mendess mendess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendess @cjpatton