Skip to content

fix: Don't try to read certs for remotely-managed tunnels (Closes #1037) #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −4
Open

fix: Don't try to read certs for remotely-managed tunnels (Closes #1037) #1524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions cmd/cloudflared/tunnel/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,12 +459,18 @@ func StartServer(
}
}

userCreds, err := credentials.Read(c.String(cfdflags.OriginCert), log)
var isFEDEndpoint bool
if err != nil {
isFEDEndpoint = false
// For remotely-managed tunnels: use endpoint info from token credentials
if c.String(TunnelTokenFlag) != "" {
isFEDEndpoint = strings.ToLower(namedTunnel.Credentials.Endpoint) == credentials.FedEndpoint
} else {
isFEDEndpoint = userCreds.IsFEDEndpoint()
// For locally-managed tunnels: check origin certificate
userCreds, err := credentials.Read(c.String(cfdflags.OriginCert), log)
if err != nil {
isFEDEndpoint = false
} else {
isFEDEndpoint = userCreds.IsFEDEndpoint()
}
}

var managementHostname string
Expand Down