feat(CI): add a GitHub Action to check spelling #513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbampton
force-pushed
the
fix-spelling
branch
2 times, most recently
from
23bfbdb to
4c7fa44
Compare
Merged
|
@jbampton could you please separate the GitHub Action and the spelling changes into 2 separate commits? Also could you rebase against Happy to merge after that, LGTM otherwise. |
jbampton
force-pushed
the
fix-spelling
branch
from
4c7fa44 to
27ec238
Compare
|
Hey @haneefmubarak this one is ready for review now 👍 |
|
Hey @haneefmubarak I made a mistake and did 2 separate PRs instead of 2 commits :( |
- Using https://github.com/client9/misspell - Run only on pull request - Pass in the -w flag to auto fix the incorrect spelling
haneefmubarak
approved these changes
Mar 9, 2021
|
Nice, it caught a spelling mistake before even merging. Alright, I'll rebase and fixup later before merging. |
|
👋 @jbampton Thank you for the feedback. We are hard at work on many things related to the deploy and build process, including a testing suite. Going forward, we are only taking care of doc contributions in this repo for developers.cloudflare.com! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #492
refs #495
refs #784
refs #787