Skip to content

[AI] Add Pareto and Jev models - #33515

Closed
shridhar-cf wants to merge 5 commits into
cloudflare:productionfrom
shridhar-cf:unbiased-pareto
Closed

shridhar-cf wants to merge 5 commits into
cloudflare:productionfrom
shridhar-cf:unbiased-pareto

Conversation

@shridhar-cf

Copy link
Copy Markdown
Collaborator

Summary\n\n- Add the Unbiased Pareto model catalog entry.\n- Add the TypeSafe Jev model catalog entry.\n- Remove the deprecated Stealth Union Alpha catalog entry.\n\n## Validation\n\n- JSON parsing validation\n- Prettier check

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning, 💡 3 suggestions found in commit 338c5e0.

👉 Fix in your agent 👈
Fix the following review findings in PR #33515 (https://github.com/cloudflare/cloudflare-docs/pull/33515).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Suggestions (3)

#### CR-c710a0b474dc · External link URL format
- **File:** `src/content/catalog-models/minimax-h3-max.json` line 324
- **Issue:** `external_info` and `terms` point at `https://platform.minimax.io/docs/guides/video-generation.md` and `.../terms-of-service.md`, while the sibling entry for the same provider/docs host (`minimax/h3.json`) uses extension-less URLs (`.../video-generation`, `.../terms-of-service`). If platform.minimax.io does not serve raw `.md` paths, these links 404 on the model page.
- **Fix:** Verify the `.md`-suffixed URLs resolve; if not, align them with the sibling entry's extension-less URLs on the same host.

#### CR-ff6eea66bf21 · Unused data field
- **File:** `src/content/catalog-models/openai-gpt-6-astra.json` line 242
- **Issue:** The metadata entry "Long-context threshold": "272,000 input tokens" is never consumed: the resolver (src/util/models/model-resolver.ts) only reads lora/function_calling/beta/partner/realtime/planned_deprecation_date from metadata, and no renderer (ModelFeatures/ModelCard/ModelDetailPage) displays it, while the pricing block advertises long-context rates with no visible threshold.
- **Fix:** If the long-context threshold is meant to be shown with the long-context pricing lines, move it into the pricing record (e.g. "Long-context threshold (input tokens)": 272000) so it renders; otherwise consider dropping the metadata key since it is dead data.

#### CR-6f521b6e69da · Third-party example asset URLs
- **File:** `src/content/catalog-models/minimax-h3.json` line 91
- **Issue:** The image-to-video and reference-image examples (lines 91, 153, 215, 222, and the corresponding TypeScript/curl snippets) point at third-party MiniMax CDNs (filecdn.minimax.chat, cdn.hailuoai.com), including a dated promo test-set path (`h3_promo_eval_ref2va/gallery/...20260724/inputs/...`). The rest of the catalog hosts example inputs/outputs on Cloudflare-controlled storage (pub-*.r2.dev, examples.aig.cloudflare.com).
- **Fix:** Consider hosting the example input images on Cloudflare-controlled storage (e.g. R2, as other catalog entries do), since the third-party URLs are outside the repo's control and may expire or be taken down, which would silently break the copy-paste examples.

---

## Conventions

### Warnings (1)

#### CV-6a4ac8988a24 · Scope accuracy
- **File:** PR-level finding
- **Issue:** The diff adds five new files (minimax-h3-max.json, minimax-h3.json, openai-gpt-6-astra.json, typesafe-jev.json, unbiased-pareto.json), but the description only accounts for two additions (Pareto, Jev) and one removal. Three new model catalog entries (minimax-h3-max, minimax-h3, openai-gpt-6-astra) are not mentioned at all, and the claimed removal of the 'Stealth Union Alpha' catalog entry has no corresponding deletion in the diff (all changed files are additions).
- **Fix:** Update the description to account for all five added catalog entries, and either include the Stealth Union Alpha removal in the diff or drop that bullet.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Suggestions (3)
File Issue
catalog-models/minimax-h3-max.json line 324 External link URL formatexternal_info and terms point at https://platform.minimax.io/docs/guides/video-generation.md and .../terms-of-service.md, while the sibling entry for the same provider/docs host (minimax/h3.json) uses extension-less URLs (.../video-generation, .../terms-of-service). If platform.minimax.io does not serve raw .md paths, these links 404 on the model page. Fix: Verify the .md-suffixed URLs resolve; if not, align them with the sibling entry's extension-less URLs on the same host.
catalog-models/openai-gpt-6-astra.json line 242 Unused data field — The metadata entry "Long-context threshold": "272,000 input tokens" is never consumed: the resolver (src/util/models/model-resolver.ts) only reads lora/function_calling/beta/partner/realtime/planned_deprecation_date from metadata, and no renderer (ModelFeatures/ModelCard/ModelDetailPage) displays it, while the pricing block advertises long-context rates with no visible threshold. Fix: If the long-context threshold is meant to be shown with the long-context pricing lines, move it into the pricing record (e.g. "Long-context threshold (input tokens)": 272000) so it renders; otherwise consider dropping the metadata key since it is dead data.
catalog-models/minimax-h3.json line 91 Third-party example asset URLs — The image-to-video and reference-image examples (lines 91, 153, 215, 222, and the corresponding TypeScript/curl snippets) point at third-party MiniMax CDNs (filecdn.minimax.chat, cdn.hailuoai.com), including a dated promo test-set path (h3_promo_eval_ref2va/gallery/...20260724/inputs/...). The rest of the catalog hosts example inputs/outputs on Cloudflare-controlled storage (pub-*.r2.dev, examples.aig.cloudflare.com). Fix: Consider hosting the example input images on Cloudflare-controlled storage (e.g. R2, as other catalog entries do), since the third-party URLs are outside the repo's control and may expire or be taken down, which would silently break the copy-paste examples.

Conventions

Warnings (1)
File Issue
PR Scope accuracy — The diff adds five new files (minimax-h3-max.json, minimax-h3.json, openai-gpt-6-astra.json, typesafe-jev.json, unbiased-pareto.json), but the description only accounts for two additions (Pareto, Jev) and one removal. Three new model catalog entries (minimax-h3-max, minimax-h3, openai-gpt-6-astra) are not mentioned at all, and the claimed removal of the 'Stealth Union Alpha' catalog entry has no corresponding deletion in the diff (all changed files are additions). Fix: Update the description to account for all five added catalog entries, and either include the Stealth Union Alpha removal in the diff or drop that bullet.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions github-actions Bot added product:ai-gateway AI Gateway: https://developers.cloudflare.com/ai-gateway/ size/xl labels Sep 18, 2026
@shridhar-cf

Copy link
Copy Markdown
Collaborator Author

Closing this PR because it included unrelated commits from the stacked branch. A clean replacement PR based on production is being opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:ai-gateway AI Gateway: https://developers.cloudflare.com/ai-gateway/ size/xl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant