Skip to content

fix: add required vitest version upper boundary for vitest-plugin - #33497

Open
kol3x wants to merge 1 commit into
cloudflare:productionfrom
kol3x:patch-4
Open

kol3x wants to merge 1 commit into
cloudflare:productionfrom
kol3x:patch-4

Conversation

@kol3x

@kol3x kol3x commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Sets an upper boundary on the Vitest version required by vitest-plugin in the corresponding note.

It currently states that "package requires Vitest 4.1 or later", but Vitest v5+ triggers a warning during test run (and failure in my case) on latest @cloudflare/vitest-plugin version:

You're running vitest@5.0.0, but this version of @cloudflare/vitest-plugin only officially supports vitest ^4.1.0.

Documentation checklist

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No issues found in commit f7e306d.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@cloudflare-docs-bot

Copy link
Copy Markdown
Contributor

Review coverage

🟡 1 ownership area needs approval.

Suggested reviewers: @for-the-kidz @irvinebroque @korinne

Needs approval Eligible approvers Suggested
workers @GregBrimble, @irvinebroque, @korinne, @MattieTK, @mikenomitch, @vy-ton, @WalshyDev, @cloudflare/deploy-config, @cloudflare/dev-plat-leads, @cloudflare/workers-runtime-1, @cloudflare/wrangler, @cloudflare/product-owners for-the-kidz, irvinebroque, korinne
CODEOWNERS mappings for displayed areas (1)
Pattern Owners
/src/content/docs/workers/ @GregBrimble, @irvinebroque, @korinne, @MattieTK, @mikenomitch, @vy-ton, @WalshyDev, @cloudflare/deploy-config, @cloudflare/dev-plat-leads, @cloudflare/workers-runtime-1, @cloudflare/wrangler, @cloudflare/product-owners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants