Workflow example review #19004
Open
Workflow example review #19004
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToriLindsay
requested review from
elithrar,
celso,
sidharthachatterjee and
a team
as code owners
github-actions
bot
added
size/s
product:workflows
Deploying cloudflare-docs with
|
| Latest commit: |
478f9e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73c2ee13.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://tori-18961-workflow-example.cloudflare-docs-7ou.pages.dev |
|
Files with changes (up to 15)
|
JoaquinGimenez1
approved these changes
Jan 3, 2025
Oxyjun
approved these changes
Jan 3, 2025
|
|
||
| As you can see, Workflows handles the responses and failures. It will retry the API calls until we get a successful response, retry fetching the backup from the URL provided, and retry saving the file to [R2](/r2). The developer doesn't have to care about any of that logic. The workflow can run until the backup file is ready, handling all the possible conditions until it is completed. | ||
| As shown in this example, Workflows handles both the responses and failures, so the developer does not have to. Workflows retries the API calls until it gets a successful response, retries fetching the backup from the URL provided, and then retries saving the file to [R2](/r2). The workflow can run until the backup file is ready, handling all of the possible conditions until it is completed. |
There was a problem hiding this comment.
Suggested change
| As shown in this example, Workflows handles both the responses and failures, so the developer does not have to. Workflows retries the API calls until it gets a successful response, retries fetching the backup from the URL provided, and then retries saving the file to [R2](/r2). The workflow can run until the backup file is ready, handling all of the possible conditions until it is completed. | |
| As shown in this example, Workflows handles both the responses and failures, thereby removing the burden from the developer. Workflows retries the following steps: | |
| - API calls until it gets a successful response | |
| - Fetching the backup from the URL provided | |
| - Saving the file to [R2](/r2) | |
| The Workflow can run until the backup file is ready, handling all of the possible conditions until it is completed. |
There was a problem hiding this comment.
@JoaquinGimenez1 Ok with you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PCX review of #18961