Fix Snippets markdown in feature table (#16130)

Co-authored-by: Nikita Cano <[email protected]>
cloudflare · Aug 14, 2024 · 5e8662d · 5e8662d
1 parent 1fae4e7
commit 5e8662d
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 8 deletions.
diff --git a/src/components/FeatureTable.astro b/src/components/FeatureTable.astro
@@ -3,6 +3,7 @@ import { z } from "astro:content";
 import { Card } from "~/components";
 import { indexPlans } from "~/util/plans";
 import { marked } from "marked";
+import { GlossaryTooltip } from "~/components";
 
 type Props = z.infer<typeof props>;
 
@@ -31,16 +32,35 @@ const properties = plan.properties;
 		</tr>
 	</thead>
 	<tbody>
-		{
-			Object.entries(properties).map(([k, v]) => {
-				const markdown = (content) => {
-					if (typeof content !== "string") return content;
+    {Object.entries(properties).map(([k, v]) => {
+      const renderTitle = (title) => {
+        const placeholder = "[[GLOSSARY_TOOLTIP_SNIPPETS_SUBREQUEST]]";
 
-					return marked.parse(content);
-				};
+        if (title.includes(placeholder)) {
+          const [beforePlaceholder, afterPlaceholder] = title.split(placeholder);
+
+          return (
+            <>
+              {beforePlaceholder}
+              <GlossaryTooltip term="Snippets subrequest" prepend="A subrequest is ">
+                subrequests
+              </GlossaryTooltip>
+              {afterPlaceholder}
+            </>
+          );
+        }
+
+        return title;
+      };
+
+	  const markdown = (content) => {
+        if (typeof content !== "string") return content;
+        return marked.parse(content);
+      };
+
 				return (
 					<tr>
-						<td set:html={markdown(v.title)} />
+						<td>{renderTitle(v.title)}</td>
 						<td set:html={markdown(v.free)} />
 						<td set:html={markdown(v.pro)} />
 						<td set:html={markdown(v.biz)} />

diff --git a/src/content/plans/index.json b/src/content/plans/index.json
@@ -1193,7 +1193,7 @@
           "ent": 50
         },
         "subrequests": {
-          "title": "Number of {{<glossary-tooltip term_id=\"Snippets subrequest\" prepend=\"A subrequest is \">}}subrequests{{</glossary-tooltip>}}",
+          "title": "Number of [[GLOSSARY_TOOLTIP_SNIPPETS_SUBREQUEST]]",
           "free": 0,
           "pro": 2,
           "biz": 3,