Fix overlay ctime stat cache#20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #17 by preserving Git's ctime stat-cache guard for writable overlay files and hardening the related overlay rename paths.
The original issue was that overlay metadata let caller-controlled mtime stand in for ctime, so Git could miss dirty files after same-size rewrites that restored mtime. This keeps ctime independent and makes rename/reconcile behavior preserve that invariant instead of creating stale overlay state.
Tests:
go build ./cmd/artifact-fs;go vet ./...;go test ./...;AFS_RUN_E2E_TESTS=1 go test -run '^TestE2EGitStatusDetectsSameSizeRewriteAfterMtimeRestore$|^TestE2EGitCommitTrackedRename$|^TestE2E$' -v .