Skip to content

Align ctime/atime with mtime in inode attrs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThoolooExpress wants to merge 1 commit into from
Closed

Align ctime/atime with mtime in inode attrs #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion internal/fusefs/fuse_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,13 +585,20 @@ func inodeAttrs(mode uint32, size uint64, typ string, mtime time.Time) fuseops.I
case "symlink":
m |= os.ModeSymlink
}
// Mirror mtime onto atime/ctime. Leaving them as zero time.Time produces
// nonsensical timestamps (Go's year-1 zero overflows when serialized into
// the FUSE attr struct), and a ctime that disagrees with the index makes
// git's stat-cache treat every base file as "potentially modified" even
// when content is intact.
return fuseops.InodeAttributes{
Size: size,
Nlink: 1,
Mode: m,
Uid: uint32(os.Getuid()),
Gid: uint32(os.Getgid()),
Atime: mtime,
Mtime: mtime,
Ctime: mtime,
}
}

Expand All @@ -610,12 +617,15 @@ func setChildEntryExpiry(entry *fuseops.ChildInodeEntry, ttl time.Duration) {
}

func (fs *ArtifactFuse) gitFileAttrs() fuseops.InodeAttributes {
now := time.Now()
return fuseops.InodeAttributes{
Size: uint64(len(fs.gitfileContent)),
Mode: 0o644,
Nlink: 1,
Uid: uint32(os.Getuid()),
Gid: uint32(os.Getgid()),
Mtime: time.Now(),
Atime: now,
Mtime: now,
Ctime: now,
}
}