Skip to content

MCPClientManager logs a recoverable discovery timeout at console.error #2300

Description

@poggersdave

Summary

In MCPClientManager, the connect/restore path that calls discoverIfConnected(serverId) reports a failed discovery with console.error, including the recoverable case where the result is Discovery timed out after 15000ms. Fleet alerting keyed on error-level logs pages on that line even though the caller can and does recover by explicitly rediscovering the server afterwards.

Seen on agents@0.23.0.

Suggestion

  • Log the discovery timeout at warn severity rather than error.
  • Emit an observability event for it so callers can react without scraping console output, e.g. _onObservabilityEvent.fire({ type: "mcp:client:discover", payload: { serverId, error }, timestamp }).

We carry both as a local patch (warn plus the event for the timeout case, console.error retained for other discovery failures). Happy to open a PR if that split is acceptable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions