Skip to content

Do not add to cache if the value is greater than 25MB #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackzh22 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not add to cache if the value is greater than 25MB #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/core/base.cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { sha256 } from "../utils/crypto.utils";
import { BaseModel } from "./base.model";

export class BaseCache {
private static kvKeySizeLimit = 512;
// https://developers.cloudflare.com/kv/platform/limits
private static kvKeySizeLimit = 512; // in bytes
private static kvValueSizeLimit = 26214400; // in bytes (25MB)

public static async get<T>(cache: KVNamespace, key: string): Promise<T | null> {
if (key.length > this.kvKeySizeLimit) return null;
Expand All @@ -16,7 +18,13 @@ export class BaseCache {
}

public static async set<T>(cache: KVNamespace, key: string, value: T, ttl: number = DefaultCacheTTL): Promise<void> {
key.length <= this.kvKeySizeLimit && await cache.put(key, JSON.stringify(value), { expirationTtl: ttl });
const keySize = this.getStringSizeInBytes(key);

const serializedValue = JSON.stringify(value);
const valueSize = this.getStringSizeInBytes(serializedValue);

keySize <= this.kvKeySizeLimit && valueSize <= this.kvValueSizeLimit &&
await cache.put(key, serializedValue, { expirationTtl: ttl });
}

public static async delete(cache: KVNamespace, key: string): Promise<void> {
Expand Down Expand Up @@ -108,4 +116,8 @@ export class BaseCache {
private static async getModifier(modifier: object | undefined) {
return modifier && !isEmpty(modifier) ? await sha256(JSON.stringify(modifier)) : "";
}
}

private static getStringSizeInBytes(value: string): number {
return new TextEncoder().encode(value).length;
}
} ``