-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appendix to data classification extension #1322
base: main
Are you sure you want to change the base?
Conversation
@rob-sessink @JemDay any thoughts? |
oops sorry @rob-sessink I didn't notice the thumbs up |
| Region | Abbreviation | Full Name | Country | | ||
|--------|--------------|-----------|---------| | ||
| Africa | POPIA | Protection of Personal Information Act | South Africa | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option 1:
change order to: Abbreviation | Full Name | Region | Country
sort by Abbr
Option 2:
Change to: For example.... (like ~3) and then have the URL to: https://unctad.org/page/data-protection-and-privacy-legislation-worldwide
@rob-sessink where on the website did you get the full list? We'd like to point to that since it's not obvious where to find it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the button "DOWNLOAD FULL DATA" on data-protection-and-privacy-legislation-worldwide which points to an excel file containing all entries. Direct link is: https://unctad.org/system/files/information-document/DP.xlsx.
Personally I would also feel more for option 2 and include a link as from a maintenance stance is better.
See cloudevents#1317 Signed-off-by: Doug Davis <[email protected]>
ok I updated the appendix. See what y'all think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Last remaining issue for PR #1317
ping @JemDay @rob-sessink