Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appendix to data classification extension #1322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duglin
Copy link
Collaborator

@duglin duglin commented Dec 12, 2024

Last remaining issue for PR #1317

ping @JemDay @rob-sessink

@duglin
Copy link
Collaborator Author

duglin commented Jan 9, 2025

@rob-sessink @JemDay any thoughts?

@duglin
Copy link
Collaborator Author

duglin commented Jan 9, 2025

oops sorry @rob-sessink I didn't notice the thumbs up

| Region | Abbreviation | Full Name | Country |
|--------|--------------|-----------|---------|
| Africa | POPIA | Protection of Personal Information Act | South Africa |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 1:
change order to: Abbreviation | Full Name | Region | Country
sort by Abbr

Option 2:
Change to: For example.... (like ~3) and then have the URL to: https://unctad.org/page/data-protection-and-privacy-legislation-worldwide

@rob-sessink where on the website did you get the full list? We'd like to point to that since it's not obvious where to find it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the button "DOWNLOAD FULL DATA" on data-protection-and-privacy-legislation-worldwide which points to an excel file containing all entries. Direct link is: https://unctad.org/system/files/information-document/DP.xlsx.

Personally I would also feel more for option 2 and include a link as from a maintenance stance is better.

@duglin
Copy link
Collaborator Author

duglin commented Jan 14, 2025

ok I updated the appendix. See what y'all think.
@jskeet @rob-sessink @JemDay

Copy link
Contributor

@rob-sessink rob-sessink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants