Changes per TAG Contrib Strategy review #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
reviewed
Sep 14, 2023
README.md
Outdated
| @@ -139,6 +145,9 @@ For SDK related comments and questions: | |||
| - Archives are at: https://lists.cncf.io/g/cncf-cloudevents-sdk/topics | |||
| - Slack: #cloudeventssdk on [CNCF's Slack workspace](http://slack.cncf.io/) | |||
|
|
|||
| For SDK specific communications, please see the main README in each | |||
| SDK's github repo - see the list of [SDKs above](#sdks). | |||
There was a problem hiding this comment.
Possibly change the link text to "list of SDKs" rather than "SDKs above"?
jskeet
reviewed
Sep 14, 2023
docs/GOVERNANCE.md
Outdated
| @@ -5,6 +5,16 @@ | |||
| This document describes the governance process under which the CloudEvents | |||
| project will manage this repository. | |||
|
|
|||
| For easy reference, additional documentation related to how this project | |||
| (and it's subprojects) operate are listed below: | |||
There was a problem hiding this comment.
(And I'd probably remove the parentheses - otherwise if you ignore the parenthetical part, you get a singular/plural mismatch.
Signed-off-by: Doug Davis <[email protected]>
|
As always, thanks for the review @jskeet Approved on the 9/14 call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc edits per the TAG Contrib Strategy Review: cncf/tag-contributor-strategy#509