-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.8.0 #300
Release 2.8.0 #300
Conversation
@captainsafia if you're happy to review this, that would be great :) (Deliberately no change in the MQTT project file - it derives everything from the existing variables. We'll need a post-release change.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/history.md
Outdated
version to reflect adopting MQTTnet version 4.3.6.1152. | ||
Fixes [#269](https://github.com/cloudevents/sdk-csharp/issues/269). | ||
- Other dependency updates: | ||
- System.Text.Json: 5.0.2 => 8.0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- System.Text.Json: 5.0.2 => 8.0.4 | |
- System.Text.Json: 5.0.2 => 8.0.4 (only used in netstandard2.0 and netstandard2.1 targets) |
A bit pedantic, but I like the clarification that you provided for System.Text.Encodings.Web
below. Maybe we can colocate the two under a separate heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good plan, will do that tomorrow morning UK time. And more pedantry is always fine by me :) Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have updated, and moved the bit about targeting .NET 8 and using framework references where possible to the top, so that the conditionality makes more sense. Please take a look - docs are so important and I really appreciate your input :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more nits
Thanks for the extra nits - I'll apply those tomorrow morning UK time, then merge (as I think those changes would be entirely uncontroversial). I'll then kick off a release. |
Changes since 2.7.1: - Add an explicit .NET 8 target to all packages. - Removed dependencies that are already included in the framework, for suitable targets. - Use a framework reference to Microsoft.AspNetCore.App instead of package frameworks, for the .NET 8 target - Release CloudNative.CloudEvents.Mqtt as 3.8.0, bumping the major version to reflect adopting MQTTnet version 4.3.6.1152. Fixes [cloudevents#269](cloudevents#269). - Other dependency updates: - AMQPNetLite and AMQPNetLite.Serialization: 2.4.2 => 2.4.11 - Apache.Avro: 1.11.1 => 1.11.3 - Newtonsoft.Json: 13.0.2 => 13.0.3 - Google.Protobuf: 3.22.0 => 3.27.3 - Confluent.Kafka: 1.6.3 => 1.9.3 - See [cloudevents#297](cloudevents#297) for consideration of a bump to 2.x. - Only for netstandard2.0 and netstandard2.1 targets: - System.Text.Encodings.Web: 6.0.0 => 8.0.0 - System.Text.Json: 5.0.2 => 8.0.4 Signed-off-by: Jon Skeet <[email protected]>
Changes since 2.7.1:
for the .NET 8 target
version to reflect adopting MQTTnet version 4.3.6.1152.
Fixes #269.
consideration of a bump to 2.x.