Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.8.0 #300

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Release 2.8.0 #300

merged 1 commit into from
Aug 7, 2024

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Aug 5, 2024

Changes since 2.7.1:

  • Add explicit .NET 8 target to all packages.
  • Removed dependencies that are already included in the framework, for suitable targets.
  • Use a framework reference to Microsoft.AspNetCore.App instead of package references,
    for the .NET 8 target
  • Release CloudNative.CloudEvents.Mqtt as 3.8.0, bumping the major
    version to reflect adopting MQTTnet version 4.3.6.1152.
    Fixes #269.
  • Other dependency updates:
    • AMQPNetLite and AMQPNetLite.Serialization: 2.4.2 => 2.4.11
    • Apache.Avro: 1.11.1 => 1.11.3
    • Newtonsoft.Json: 13.0.2 => 13.0.3
    • Google.Protobuf: 3.22.0 => 3.27.3
    • Confluent.Kafka: 1.6.3 => 1.9.3
      • See #297 for
        consideration of a bump to 2.x.
    • Only for netstandard2.0 and netstandard2.1 targets:
      • System.Text.Encodings.Web: 6.0.0 => 8.0.0
      • System.Text.Json: 5.0.2 => 8.0.4

@jskeet jskeet requested a review from JoshLove-msft August 5, 2024 10:31
@jskeet
Copy link
Contributor Author

jskeet commented Aug 5, 2024

@captainsafia if you're happy to review this, that would be great :)

(Deliberately no change in the MQTT project file - it derives everything from the existing variables. We'll need a post-release change.)

Copy link
Contributor

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

docs/history.md Outdated
version to reflect adopting MQTTnet version 4.3.6.1152.
Fixes [#269](https://github.com/cloudevents/sdk-csharp/issues/269).
- Other dependency updates:
- System.Text.Json: 5.0.2 => 8.0.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- System.Text.Json: 5.0.2 => 8.0.4
- System.Text.Json: 5.0.2 => 8.0.4 (only used in netstandard2.0 and netstandard2.1 targets)

A bit pedantic, but I like the clarification that you provided for System.Text.Encodings.Web below. Maybe we can colocate the two under a separate heading?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good plan, will do that tomorrow morning UK time. And more pedantry is always fine by me :) Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated, and moved the bit about targeting .NET 8 and using framework references where possible to the top, so that the conditionality makes more sense. Please take a look - docs are so important and I really appreciate your input :)

Copy link
Contributor

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits

docs/history.md Outdated Show resolved Hide resolved
docs/history.md Outdated Show resolved Hide resolved
@jskeet
Copy link
Contributor Author

jskeet commented Aug 6, 2024

Thanks for the extra nits - I'll apply those tomorrow morning UK time, then merge (as I think those changes would be entirely uncontroversial). I'll then kick off a release.
Thanks so much!

Changes since 2.7.1:

- Add an explicit .NET 8 target to all packages.
- Removed dependencies that are already included in the framework, for suitable targets.
- Use a framework reference to Microsoft.AspNetCore.App instead of package frameworks,
  for the .NET 8 target
- Release CloudNative.CloudEvents.Mqtt as 3.8.0, bumping the major
  version to reflect adopting MQTTnet version 4.3.6.1152.
  Fixes [cloudevents#269](cloudevents#269).
- Other dependency updates:
  - AMQPNetLite and AMQPNetLite.Serialization: 2.4.2 => 2.4.11
  - Apache.Avro: 1.11.1 => 1.11.3
  - Newtonsoft.Json: 13.0.2 => 13.0.3
  - Google.Protobuf: 3.22.0 => 3.27.3
  - Confluent.Kafka: 1.6.3 => 1.9.3
    - See [cloudevents#297](cloudevents#297) for
      consideration of a bump to 2.x.
  - Only for netstandard2.0 and netstandard2.1 targets:
    - System.Text.Encodings.Web: 6.0.0 => 8.0.0
    - System.Text.Json: 5.0.2 => 8.0.4

Signed-off-by: Jon Skeet <[email protected]>
@jskeet jskeet merged commit 54cbd3c into cloudevents:main Aug 7, 2024
2 checks passed
@jskeet jskeet deleted the release branch August 7, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency MQTTnet out of date and has breaking changes.
2 participants