Skip to content

Conversation

lhoss
Copy link
Contributor

@lhoss lhoss commented May 15, 2019

…(like java, rngd, mysql)

Motivation:

@dbeech
Copy link
Contributor

dbeech commented Aug 27, 2019

Would tags / skip_tags be a better way of achieving this?
https://docs.ansible.com/ansible/latest/user_guide/playbooks_tags.html

@lhoss lhoss force-pushed the new_vars_to_disable_playbook_parts branch from 54c969b to da3100b Compare September 13, 2019 15:45

- name: Apply temporary workaround for Cloudera Manager issue OPSAPS-36322
include: 36322.yml
when: cluster_install_groups_users | default(false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw @dbeech is this 'temporary' workaround still needed in the playbook (maybe for older CDH 5.x versions ?).
During my initial tests with CDH 6.2, I had this part ignored, and the deployment worked (at least upto the CM install + configuration)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think this is required any more. The bug listed is 3 years old and wasn't even commonly encountered -- I think the original root cause was that selinux was enabled and this messed up the user creation through CM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then I propose to get that whole logic out in a future PR
( but keep my addition in for now, assuming you are OK with the rest)

@lhoss
Copy link
Contributor Author

lhoss commented Sep 13, 2019

Would tags / skip_tags be a better way of achieving this?

Simply using tags can be good enough in some cases, but it often gets problematic with tags outside the main playbook ( which would be required for the cluster_install_groups_users toggle)

To avoid creating a bunch of new 'group vars' (in the all file .. we should add the '.yml' extension btw for proper yml handling in editors, like VScode), I could make undocumented vars by changing the when check(s) to:

      when: cluster_install_rngd | default(true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants