Skip to content

Commit

Permalink
Removed unnecessary optimization and warning message (#369)
Browse files Browse the repository at this point in the history
  • Loading branch information
mangchiandjjoe authored Mar 29, 2018
1 parent 51d5bf6 commit d07f3cb
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
#
# A Bazel (http://bazel.io) workspace for the Google Cloud Endpoints runtime.

ESP_TOOL = "7c1cac2aa0613f40200acb64342b23823e5a3621"
ESP_TOOL = "4fba523678a197983b572e1219f3e4fe968b1889"

git_repository(
name = "nginx",
Expand Down
5 changes: 0 additions & 5 deletions src/api_manager/fetch_metadata.cc
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,11 @@ void GlobalFetchGceMetadata(std::shared_ptr<context::GlobalContext> context,
env->LogDebug("Metadata fetch previously failed. Skipping with error.");
continuation(Status(Code::INTERNAL, kFailedMetadataFetch));
return;
case GceMetadata::FETCHING:
env->LogDebug("Another request fetching metadata. Duplicate fetch.");
continuation(Status(Code::UNAVAILABLE, kFailedMetadataFetch));
return;
case GceMetadata::NONE:
default:
env->LogDebug("Fetching metadata.");
}

context->gce_metadata()->set_state(GceMetadata::FETCHING);
FetchMetadata(
context.get(), kComputeMetadata,
[context, continuation](Status status, std::map<std::string, std::string>,
Expand Down
2 changes: 0 additions & 2 deletions src/api_manager/gce_metadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ class GceMetadata {
public:
enum FetchState {
NONE = 0,
// Fetching,
FETCHING,
// Fetch failed
FAILED,
// Data is go
Expand Down
2 changes: 1 addition & 1 deletion src/api_manager/service_control/aggregated.cc
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ Status Aggregated::Report(const ReportRequestInfo& info) {
if (service_control_proto_.service_config_id() !=
response->service_config_id()) {
if (mismatched_report_config_id_ != response->service_config_id()) {
env_->LogWarning(
env_->LogDebug(
"Received non-matching report response service config ID: '" +
response->service_config_id() + "', requested: '" +
service_control_proto_.service_config_id() + "'");
Expand Down

0 comments on commit d07f3cb

Please sign in to comment.