Enable asan tests for non t unit-tests (#597)

* fix asan test to only run non-t tests

* revert nginx.bzl changes

* test t tests

* echo gcc version

* disable jwt_validator_test

* remove t tests

.bazelrc

@@ -5,6 +5,7 @@ build:asan --copt -O1
 build:asan --copt -fno-omit-frame-pointer
 build:asan --copt -Wno-error=maybe-uninitialized
 build:asan --linkopt -fsanitize=address
+build:asan --test_tag_filters=-no_asan
 
 # Thread sanitizer
 build:tsan --strip=never

Jenkinsfile

@@ -52,7 +52,7 @@ SUPPORTED_STAGES = [
 ]
 
 // Supported VM Images
-SLAVE_IMAGE = 'gcr.io/endpoints-jenkins/debian-9:0.6'
+SLAVE_IMAGE = 'gcr.io/endpoints-jenkins/debian-9:0.8'
 
 // Release Qualification end to end tests.
 // If RAPTURE_REPO build parameter is set only those test will run.

jenkins/slaves/Makefile

@@ -1,5 +1,5 @@
 PROJECT = endpoints-jenkins
-VERSION = 0.6
+VERSION = 0.8
 TOOLS_BUCKET = endpoints-tools
 
 # Note: The build directory is the root of the istio/test-infra repository, not ./

script/linux-install-software

@@ -39,7 +39,6 @@ DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 . ${DIR}/tools/linux-install-bazel || error_exit "Cannot load Bazel install script"
 . ${DIR}/tools/linux-install-docker || error_exit "Cannot load Docker install script"
 . ${DIR}/tools/linux-install-clang || error_exit "Cannot load Clang install script"
-. ${DIR}/tools/linux-install-gcc || error_exit "Cannot load gcc install script"
 . ${DIR}/tools/linux-install-gcloud || error_exit "Cannot load gcloud install script"
 . ${DIR}/tools/linux-install-wrk || error_exit "Cannot load wrk install script"
 . ${DIR}/tools/linux-install-nodejs || error_exit "Cannot load nodejs install script"
@@ -114,7 +113,6 @@ else
   mkdir -p "${TOOLS_DIR}" -m 0777
 fi
 update_clang
-install_gcc
 update_gcloud
 update_bazel
 install_docker_for_debian9

script/presubmits

@@ -62,8 +62,19 @@ function build_and_test() {
     || { echo "${error}..."; return 1; }
 }
 
+# For now, asan doesn't work for "t" tests Nginx has some global memory not freed,
+# TODO: find a way to supress these memory leaks from Nginx.
+function test_asan() {
+  local message='Running asan unit-tests, integration tests & NGINX tests'
+  local error='Asan Unit, Integration, NGINX, start_esp tests failed'
+  echo "${message}..."
+  ${BAZEL} ${BAZEL_ARGS} test --test_output=errors --config=asan \
+      //src/api_manager/... //src/grpc/... \
+    || { echo "${error}..."; return 1; }
+}
+
 function asan() {
-  build_and_test 'asan' || return 1
+  test_asan || return 1
 }
 
 function tsan() {

script/run-presubmit

@@ -59,6 +59,9 @@ done
 LOG_FILE="${LOG_DIR}/${SCENARIO}.log"
 JSON_FILE="${LOG_DIR}/${SCENARIO}.json"
 
+echo "gcc version:"
+gcc --version
+
 case $SCENARIO in
   asan) log_output asan;;
   build-and-test) log_output build_and_test;;

src/api_manager/auth/lib/BUILD

@@ -48,6 +48,9 @@ cc_test(
         "auth_jwt_validator_test.cc",
     ],
     linkstatic = 1,
+    # With gcc-6.3.0 from debian9, asan test has false alarm
+    # inside openSSL code.
+    tags = ["no_asan"],
     deps = [
         ":lib",
         "//external:googletest_main",