Support grunt-contrib-jasmine 1.2.0 and newer #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and an explicit computation of the temporary diretory, because grunt-contrib-jasmine broke their interface between 1.0.3 and 1.2.0. (!!!) Upgrade grunt-contrib-jasmine to 2.0.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left upgrading
grunt-contrib-jasmineto the most recent version out of #94. This PR bases on #94 and uses a different way to copy files to temp directory, compatible with both older and newer versions, thangrunt-contrib-jasmine1.2.0.grunt-contrib-jasminebroke their interface between 1.0.3 and 1.2.0 without increasing the major version number. (!!!) The methodtask.copyTempFiledoes not copy the source file to the temp directory any more. You would have provide the full path to the temp directory yourself. It made this method a pure wrapper ofgrunt.file.copywith no added functionality and a confusing name. This should be discussed withgrunt-contrib-jasminedevelopers.