Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote intro line + migrate all tests #55

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Quote intro line + migrate all tests #55

merged 5 commits into from
Jul 3, 2024

Conversation

thomasst
Copy link
Member

@thomasst thomasst commented Jul 2, 2024

  • For both plain text and HTML, you can now say quote_intro_line=True to include the line introducing the quoted text in the quoted section.
  • Migrated all the tests over
  • Technically backwards incompatible because I added * to the function signature, so just bumping to 0.4.0.

@thomasst thomasst requested a review from AlecRosenbaum July 2, 2024 03:24
quotequail/_internal.py Outdated Show resolved Hide resolved
self.assertEqual(result["date"], "Wednesday, July 09, 2014 10:27 AM")
self.assertEqual(result["subject"], "The subject!")
self.assert_equal_to_file(
result["html"], "outlook_forward_unwrapped.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these files still used somewhere or were they inlined?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 46864a2 I added tests/test_unwrap_html.py but forgot to remove the tests. All the unwrap_html tests I'm removing here should be there.

@thomasst thomasst merged commit 3f8e26d into master Jul 3, 2024
12 checks passed
@wojcikstefan wojcikstefan deleted the quote-intro-line branch July 9, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants