Skip to content

[Fix #57] Add inf-clojure-meta #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

charignon
Copy link
Contributor

@charignon charignon commented Jan 19, 2019

Summary

This commit addresses
#57 (Add an interactive
command to display a var's metadata) by adding an interactive command inf-clojure-meta to show metadata of a form at point.

This command works with clojure, lumo and planck alike.

Test Plan

Manually tested the command through inf-clojure using clojure, lumo and planck. I put my cursor on a
form and ran it interactively, it displayed the metadata in the inf buffer.
Specifically I tested with (with-meta [1 2 3] {:data "hello"}) which printed {:data "hello"} in the inf-clojure buffer.


  • The commits are consistent with our [contribution guidelines][1]
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • [NO] You've updated the readme (if adding/changing user-visible functionality)
    • It seems that we generally document higher level features and this does not warrant a change to the readme, let me know if you think that's necessary.

#### Summary

This commit addresses clojure-emacs#57 (Add an interactive
command to display a var's metadata) by adding an interactive command `inf-clojure-meta` to show metadata of a form at point.

This command works with clojure, lumo and planck alike.

#### Test Plan
Manually tested the command using clojure, lumo and planck. I put my cursor on a
form and ran it interactively, it displayed the metadata in the repl buffer.
Specifically I tested with `(with-meta [1 2 3] {:data "hello"})` and it printed `{:data "hello"}`
@charignon
Copy link
Contributor Author

charignon commented Jan 19, 2019

Could you suggest an example of syntax quirk that you think would be problematic? @arichiardi

@arichiardi
Copy link
Contributor

I might need to think about this through and see what other functions are doing, sorry, maybe it is actually already alright

@arichiardi
Copy link
Contributor

@charignon sorry for the delay, let me try this PR.

...
💻
...

So I tried the branch, but I fail to see how it is going to work at the moment. I was expecting so do something like:

(require '[clojure.string :as string])

cljs.user=> |clojure.string/blank?

and see the meta but that did not happen because we are missing the var around the meta call like (meta (var clojure.string/blank?))

I feel I am misunderstanding the use case you want to address here (in which case, my fault 😄)

@bbatsov
Copy link
Member

bbatsov commented Feb 9, 2022

This hasn't had any activity in years, so I'll close it.

@bbatsov bbatsov closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants