[stacktrace] Allow inspecting ex-data directly #3807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
inspect-ex-data
branch
from
8a47f7b to
b7c3a16
Compare
|
@alexander-yakushev Nice! Looks exactly what I was looking for. Thank You! I will give it a try tomorrow morning! |
bbatsov
reviewed
Apr 10, 2025
| Within `*cider-error*`, when clicking directly a top-level exception (any of | ||
| them in the cause chain), that specific exception will be inspected with the | ||
| CIDER xref:debugging/inspector.adoc[Inspector]. You can also click on the | ||
| rendered exception data to inspect it directly. |
There was a problem hiding this comment.
Might be a good a idea to add here a couple of screenshots or some short gif video.
bbatsov
approved these changes
Apr 10, 2025
bbatsov
reviewed
Apr 10, 2025
cider-inspector.el
Outdated
| (interactive) | ||
| (cl-assert (numberp index)) | ||
| (let ((result (cider-sync-request:inspect-last-exception index))) | ||
| (let ((result (cider-nrepl-send-sync-request `("op" "inspect-last-exception" |
There was a problem hiding this comment.
I'd probably put a line break before the request list params to narrow the formatting here.
bbatsov
reviewed
Apr 10, 2025
bbatsov
reviewed
Apr 10, 2025
bbatsov
reviewed
Apr 10, 2025
alexander-yakushev
force-pushed
the
inspect-ex-data
branch
3 times, most recently
from
be08c59 to
984dd1f
Compare
|
Hi, I just tried it, it works as expected and I like it! Thanks again! |
alexander-yakushev
force-pushed
the
inspect-ex-data
branch
from
984dd1f to
57d38fd
Compare
alexander-yakushev
force-pushed
the
inspect-ex-data
branch
from
57d38fd to
9acb56a
Compare
alexander-yakushev
force-pushed
the
inspect-ex-data
branch
from
9acb56a to
704f7a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR: clojure-emacs/cider-nrepl#930
Addresses (partially): #3804.
Here's the end result:
The screenshot doesn't show the mouse cursor, but the printed ex-data is now a clickable button, it gets highlighted on hover, you can click it or press Enter on it or
poriand this will open the inspector showing just theex-data(not the entire exception).Whole exceptions are still inspectable by clicking the exception classname or Enter or i or p.
I also shuffled some newlines again to fix minor highlighting issues with the stacktraces.