Skip to content

Conversation

kim
Copy link
Contributor

@kim kim commented Sep 26, 2025

Move the global.json file to the repo root, which should make dotnet
resolve the correct SDK regardless of the directory it is run in.

Where a copy of the global.json file is needed, symlink it to the one at
the root.

Should fix "C#/Unity - Test Suite".

kim added 3 commits September 26, 2025 10:18
Move the global.json file to the repo root, which should make `dotnet`
resolve the correct SDK regardless of the directory it is run in.

Where a copy of the global.json file is needed, symlink it to the one at
the root.
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and seems to fix the C# Test Suite at least. The Unity stuff can be a different PR.

@bfops
Copy link
Collaborator

bfops commented Sep 30, 2025

One concern for me is whether the template global._json will be correct in C# projects generated by the CLI, but since our CI passes I assume it's still working correctly!

@bfops bfops linked an issue Sep 30, 2025 that may be closed by this pull request
@bfops
Copy link
Collaborator

bfops commented Sep 30, 2025

I'm going to merge this since it fixes the Test Suite.

@bfops bfops marked this pull request as ready for review September 30, 2025 16:39
@bfops bfops added this pull request to the merge queue Sep 30, 2025
Merged via the queue into master with commit 43389dd Sep 30, 2025
23 of 25 checks passed
bfops pushed a commit that referenced this pull request Oct 1, 2025
Move the global.json file to the repo root, which should make `dotnet`
resolve the correct SDK regardless of the directory it is run in.

Where a copy of the global.json file is needed, symlink it to the one at
the root.

Should fix "C#/Unity - Test Suite".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix C# bindings tests
2 participants