cli: pre-publish endpoint call. #3278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
Shubham8287
commented
Sep 23, 2025
Shubham8287
force-pushed
the
shub/update-disconnect-clients
branch
from
3a0e6bd to
49cfb51
Compare
Shubham8287
force-pushed
the
shub/pre-publish-in-cli
branch
from
cb0d206 to
6ef506d
Compare
Shubham8287
force-pushed
the
shub/pre-publish-in-cli
branch
from
c87c871 to
09d9377
Compare
Co-authored-by: Phoebe Goldman <[email protected]> Signed-off-by: Shubham Mishra <[email protected]>
Shubham8287
force-pushed
the
shub/pre-publish-in-cli
branch
from
47954f5 to
a970761
Compare
gefjon
approved these changes
Sep 26, 2025
bfops
reviewed
Sep 26, 2025
1 task
bfops
reviewed
Sep 26, 2025
bfops
approved these changes
Sep 26, 2025
Shubham8287
commented
Sep 26, 2025
Co-authored-by: Zeke Foppa <[email protected]> Signed-off-by: Shubham Mishra <[email protected]>
Shubham8287
force-pushed
the
shub/pre-publish-in-cli
branch
from
50c6d72 to
af44921
Compare
Shubham8287
changed the base branch from
shub/update-disconnect-clients
to
master
Signed-off-by: Shubham Mishra <[email protected]>
Shubham8287
force-pushed
the
shub/pre-publish-in-cli
branch
from
ee03bd2 to
c6a0497
Compare
Shubham8287
force-pushed
the
shub/pre-publish-in-cli
branch
from
c6a0497 to
b59dc1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
PR contains:
pre_publishendpoint when publishing a module.--yesflag will not bypasses the break clients warning prompt — an extra confirmation is now required. For CI, a hidden flag--break-clientsis added.client-api-*crates for consistency reasons.pre_publishroute to accept similar Body size limit aspublishroute.API and ABI breaking changes
an additive API change, does not break anything.
Expected complexity level and risk
2
Testing