Fix tools/publish-crates.sh
#3268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
added
release-any
bfops
commented
Sep 23, 2025
| crate="$(basename "$path")" | ||
| # Add owners | ||
| echo "INFO: Adding owners for $crate..." | ||
| echo "Adding owners for $crate..." |
There was a problem hiding this comment.
idk why we printed INFO: here and below, and not in other places 🤷
jdetter
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes two problems introduced in #3185:
--directoriesoption onfind-publish-list.pywas not printing directoriespublish-crates.shscript was using an undefined variable.API and ABI breaking changes
No breaking changes
Expected complexity level and risk
1
Testing
This was used to publish crates in the release yesterday.