test & ci: bump deps (#322)

Of note:
- codecov action renamed arg file->files
- setup-clojure action now installs via clj-msi on Windows (woot!)
- new version of kondo; it found a couple of redundant nested calls (fixed)!
- bump lib tests libs
- add jdk23 to ci testing

.clj-kondo/taoensso/encore/config.edn

@@ -1 +1,5 @@
-{:hooks {:analyze-call {taoensso.encore/defalias taoensso.encore/defalias}}}
+{:hooks
+ {:analyze-call
+  {taoensso.encore/defalias    taoensso.encore/defalias
+   taoensso.encore/defn-cached taoensso.encore/defn-cached
+   taoensso.encore/defonce     taoensso.encore/defonce}}}

.clj-kondo/taoensso/encore/taoensso/encore.clj

@@ -1,16 +1,51 @@
 (ns taoensso.encore
+  "I don't personally use clj-kondo, so these hooks are
+  kindly authored and maintained by contributors.
+  PRs very welcome! - Peter Taoussanis"
+  (:refer-clojure :exclude [defonce])
   (:require
    [clj-kondo.hooks-api :as hooks]))
 
-(defn defalias [{:keys [node]}]
+(defn defalias
+  [{:keys [node]}]
   (let [[sym-raw src-raw] (rest (:children node))
-        src (if src-raw src-raw sym-raw)
-        sym (if src-raw
-              sym-raw
-              (symbol (name (hooks/sexpr src))))]
-    {:node (with-meta
-             (hooks/list-node
-               [(hooks/token-node 'def)
-                (hooks/token-node (hooks/sexpr sym))
-                (hooks/token-node (hooks/sexpr src))])
-             (meta src))}))
+        src (or src-raw sym-raw)
+        sym (if src-raw sym-raw (symbol (name (hooks/sexpr src))))]
+    {:node
+     (with-meta
+       (hooks/list-node
+         [(hooks/token-node 'def)
+          (hooks/token-node (hooks/sexpr sym))
+          (hooks/token-node (hooks/sexpr src))])
+       (meta src))}))
+
+(defn defn-cached
+  [{:keys [node]}]
+  (let [[sym _opts binding-vec & body] (rest (:children node))]
+    {:node
+     (hooks/list-node
+       (list
+         (hooks/token-node 'def)
+         sym
+         (hooks/list-node
+           (list*
+             (hooks/token-node 'fn)
+             binding-vec
+             body))))}))
+
+(defn defonce
+  [{:keys [node]}]
+  ;; args = [sym doc-string? attr-map? init-expr]
+  (let [[sym & args] (rest (:children node))
+        [doc-string args]    (if (and (hooks/string-node? (first args)) (next args)) [(hooks/sexpr (first args)) (next  args)] [nil        args])
+        [attr-map init-expr] (if (and (hooks/map-node?    (first args)) (next args)) [(hooks/sexpr (first args)) (fnext args)] [nil (first args)])
+
+        attr-map (if doc-string (assoc attr-map :doc doc-string) attr-map)
+        sym+meta (if attr-map (with-meta sym attr-map) sym)
+        rewritten
+        (hooks/list-node
+          [(hooks/token-node 'clojure.core/defonce)
+           sym+meta
+           init-expr])]
+
+    {:node rewritten}))

.github/workflows/code-coverage.yml

@@ -20,9 +20,9 @@ jobs:
         run: bb test-coverage
 
       - name: Upload Code Coverage Results
-        uses: codecov/codecov-action@v4
+        uses: codecov/codecov-action@v5
         with:
           fail_ci_if_error: true # optional (default = false)
-          file: ./target/coverage/codecov.json
+          files: ./target/coverage/codecov.json
           token: ${{ secrets.CODECOV_TOKEN }} # required
           verbose: true # optional (default = false)

.github/workflows/libs-test.yml

@@ -55,7 +55,7 @@ jobs:
       ## instead of using lein bundled with github actions image.
       ## Upcoming 2.11.2 might fix, can optionally revisit in the future.
       - name: Install Lein
-        uses: DeLaGuardo/setup-clojure@12.5
+        uses: DeLaGuardo/setup-clojure@13.0
         with:
           lein: 2.10.0
 

.github/workflows/native-image-test.yml

@@ -17,7 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ windows, ubuntu, macos ]
-        java-version: [ '23' ]
+        java-version: [ '23.0.1' ]
         test: [ native, native-sci ]
         clojure-version: [ '1.12' ]
 

.github/workflows/shared-setup/action.yml

@@ -39,25 +39,11 @@ runs:
         java-version: ${{ inputs.jdk }}
       if: inputs.jdk != 'skip'
 
-    - name: Install Babashka
-      uses: DeLaGuardo/setup-clojure@12.5
+    - name: Install Babashka & Clojure
+      uses: DeLaGuardo/setup-clojure@13.0
       with:
         bb: 'latest'
-
-    - name: Install Clojure (windows)
-      # On windows, deps.clj's deps.exe is used in place of clojure to avoid complexities of official clojure install
-      shell: ${{ inputs.shell }}
-      run: |
-       PowerShell -Command "iwr -useb https://raw.githubusercontent.com/borkdude/deps.clj/master/install.ps1 | iex"
-       Rename-Item $HOME\deps.clj\deps.exe clojure.exe
-       echo "$HOME\deps.clj" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
-      if: runner.os == 'Windows'
-
-    - name: Install Clojure (macos, linux)
-      uses: DeLaGuardo/[email protected]
-      with:
         cli: 'latest'
-      if: runner.os != 'Windows'
 
     - name: Tools Versions
       shell: ${{ inputs.shell }}

bb.edn

@@ -8,7 +8,7 @@
         lread/status-line {:git/url "https://github.com/lread/status-line.git"
                            :sha "cf44c15f30ea3867227fa61ceb823e5e942c707f"}
         etaoin/etaoin {:mvn/version "1.1.42"}
-        io.github.babashka/neil {:git/tag "v0.3.67" :git/sha "054ca51"}}
+        io.github.babashka/neil {:git/tag "v0.3.68", :git/sha "78ffab1"} }
  :tasks {;; setup
          :requires ([clojure.string :as string]
                     [lread.status-line :as status])

deps.edn

@@ -50,7 +50,7 @@
            ;;
            :lint-cache {:replace-paths ["src"]} ;; when building classpath we want to exclude resources
                                                 ;; so we do not pick up our own clj-kondo config exports
-           :clj-kondo {:extra-deps {clj-kondo/clj-kondo {:mvn/version "2024.09.27"}}
+           :clj-kondo {:extra-deps {clj-kondo/clj-kondo {:mvn/version "2024.11.14"}}
                        :override-deps {org.clojure/clojure {:mvn/version "1.12.0"}}
                        :main-opts ["-m" "clj-kondo.main"]}
 
@@ -158,7 +158,7 @@
            ;;
            ;; Maintenance support
            ;;
-           :outdated {:extra-deps {com.github.liquidz/antq {:mvn/version "2.9.1232"}
+           :outdated {:extra-deps {com.github.liquidz/antq {:mvn/version "2.11.1250"}
                                    org.slf4j/slf4j-simple {:mvn/version "2.0.16"} ;; to rid ourselves of logger warnings
                                    }
                       :override-deps {org.clojure/clojure {:mvn/version "1.12.0"}}

doc/02-developer-guide.adoc

@@ -42,13 +42,8 @@ https://scoop.sh/[Scoop] offers an easy way to install tools.
 @littleli is doing a great job  w/maintaining https://github.com/littleli/scoop-clojure[scoop apps for Clojure, Babashka and other tools] and this is how I installed Babashka.
 
 ==== Clojure
-We all choose our own paths, but for me, using https://github.com/borkdude/deps.clj[deps.clj] instead of https://github.com/clojure/tools.deps.alpha/wiki/clj-on-Windows[Clojure's PowerShell Module] offered me no fuss no muss Clojure on Windows and GitHub Actions on Windows.
-I decided to install deps.clj not through scoop but through https://github.com/borkdude/deps.clj#windows[the deps.clj `install.ps1` script].
-This makes it simple to treat `deps.exe` as if it were the official `clojure` via a simple rename:
-
-----
-Rename-Item $HOME\deps.clj\deps.exe clojure.exe
-----
+Now that the Clojure core team is recommends https://github.com/casselc/clj-msi[clj-msi] life is easier.
+If you are not already installing via `clj-msi` on Windows, you'll want to do so.
 
 ==== GraalVM
 You'll have your own preference, but I find it convenient to install GraalVM on Windows via scoop.