Repository navigation
release workflow rework - #411
Merged
Merged
Conversation
Use local build scripts (was using com.github.liquidz/build.edn, which is, don't get me wrong, very nice, but the future of project is uncertain). Local scripts cribbed from other clj-commons projects Retain prefix-less git version tag (i.e. 1.2.3 not v1.2.3). Same for docker image tag. Release is now triggered by pushed release tag (was manual trigger on workflow via GitHub web UI). This is the preference of my clj-commons co-maintainers and consistent with other clj-commons projects. Version is major.minor.<release count> (was major.minor.<commit count>). This is new maintainer preference, consistent with other clj-commons projects I maintain. Also has advantage of being able to reference a future release explicitly. Track current version and last released version with #374 in mind. Retire GitHub action workflow release.yml, replaced by publish.yml. Move docker publish work to babashka task. - no longer "warming cache" with a pre-pull - no longer double-building: build once, push tags afterward. Dockerfile maintenance: - bump to Java 27 - move to two phase build - (still no Gradle installed) - (still running from Java, did not switch to babashka) Enthusiastically embrace new `:keys!` destructuring. Add maintainer guide to describe release workflow for current and future Antq maintainers. Closes #378 Closes #313
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use local build scripts (was using com.github.liquidz/build.edn, which is, don't get me wrong, very nice, but the future of project is uncertain). Local scripts cribbed from other clj-commons projects
Retain prefix-less git version tag (i.e. 1.2.3 not v1.2.3). Same for docker image tag.
Release is now triggered by pushed release tag (was manual trigger on workflow via GitHub web UI). This is the preference of my clj-commons co-maintainers and consistent with other clj-commons projects.
Version is major.minor. (was major.minor.). This is new maintainer preference, consistent with other clj-commons projects I maintain. Also has advantage of being able to reference a future release explicitly.
Track current version and last released version with #374 in mind.
Retire GitHub action workflow release.yml, replaced by publish.yml.
Move docker publish work to babashka task.
Dockerfile maintenance:
Enthusiastically embrace new
:keys!destructuring.Add maintainer guide to describe release workflow for current and future Antq maintainers.
Closes #378
Closes #313
We appreciate your contribution. Please complete the following checklist (and leave it in as part of your PR):
I have: