Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strategies types from OAuth-specific to general SSO #1907

Merged

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Jan 16, 2025

Related: #1908

Explanation:

⚠️ Relies on clerk/javascript#4880
⚠️ Referenced by #1908
⚠️ Needs redirects: https://github.com/clerk/clerk/pull/941

We have the enterprise_sso strategy (SAML, EASIE, OIDC) which isn't social "OAuth" specific and should be referenced on the docs.

I've updated the "OAuth types" page to "SSO types" to reference all strategies related to Single Sign-On, from social OAuth, to enterprise protocols.

This PR:

  • Updates "OAuth types" page to "SSO types"
  • Introduces "EnterpriseSSOStrategy" on the strategies reference from @clerk/types

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1907

@LauraBeatris LauraBeatris force-pushed the laura/update-sso-strategy branch from 2b98e69 to aac16b4 Compare January 16, 2025 01:31
@LauraBeatris LauraBeatris marked this pull request as ready for review January 16, 2025 01:57
@LauraBeatris LauraBeatris requested a review from a team as a code owner January 16, 2025 01:57
Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## How to use the `useSSO()` hook

<Include src="_partials/expo/sso-custom-flow" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this partial file uploaded? I can't find it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victoriaxyz My bad, there was an issue with my Git history switching between branches and I've committed useSSO from #1908

Fixed on d30a75c

Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LauraBeatris, here's my review.

Update

  • fix title
  • fix function name and signature

Notes

  • missing partial: _partials/expo/sso-custom-flow
  • this file is also being edited in the other PR: docs/references/expo/use-sso.mdx

@alexisintech alexisintech changed the base branch from main to laura/orgs-471-update-docs-for-clerkexpo January 17, 2025 21:16
@alexisintech alexisintech merged commit c18c0ab into laura/orgs-471-update-docs-for-clerkexpo Jan 17, 2025
1 check passed
@alexisintech alexisintech deleted the laura/update-sso-strategy branch January 17, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants