-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update strategies types from OAuth-specific to general SSO #1907
Update strategies types from OAuth-specific to general SSO #1907
Conversation
Hey, here’s your docs preview: https://clerk.com/docs/pr/1907 |
2b98e69
to
aac16b4
Compare
aac16b4
to
416a94a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LauraBeatris, I can't find the partial file or SSO function:
docs/references/expo/use-sso.mdx
Outdated
|
||
## How to use the `useSSO()` hook | ||
|
||
<Include src="_partials/expo/sso-custom-flow" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this partial file uploaded? I can't find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victoriaxyz My bad, there was an issue with my Git history switching between branches and I've committed useSSO
from #1908
Fixed on d30a75c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LauraBeatris, here's my review.
Update
- fix title
- fix function name and signature
Notes
- missing partial:
_partials/expo/sso-custom-flow
- this file is also being edited in the other PR:
docs/references/expo/use-sso.mdx
c18c0ab
into
laura/orgs-471-update-docs-for-clerkexpo
Related: #1908
Important
🔎 Previews:
Explanation:
We have the
enterprise_sso
strategy (SAML, EASIE, OIDC) which isn't social "OAuth" specific and should be referenced on the docs.I've updated the "OAuth types" page to "SSO types" to reference all strategies related to Single Sign-On, from social OAuth, to enterprise protocols.
This PR:
@clerk/types
Checklist