Document available expo clerk components #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed you resolved comments that weren't resolved, so I went ahead and addressed them in a commit. For future PR's, please address all comments before asking for another review/approval ! The code for those un-addressed comments was broken, and that can't be shipped to the docs. |
Co-authored-by: Alexis Aguilar <[email protected]>
NWylynko
commented
Jan 17, 2025
docs/components/protect.mdx
Outdated
| import { Protect } from '@clerk/clerk-expo' | ||
| import { ReactNode } from 'react' | ||
|
|
||
| export default function ProtectPage({ children }: { children: ReactNode }) { |
There was a problem hiding this comment.
A page component, rendered by a expo-router won't receive children props. I could change the example to being a layout component instead.
NWylynko
commented
Jan 17, 2025
docs/components/protect.mdx
Outdated
| import { Protect } from '@clerk/clerk-expo' | ||
| import { ReactNode } from 'react' | ||
|
|
||
| export default function ProtectPage({children}: {children: ReactNode}) { |
There was a problem hiding this comment.
A page component, rendered by a expo-router won't receive children props. I could change the example to being a layout component instead.
alexisintech
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
🔎 Previews:
Explanation:
https://linear.app/clerk/issue/DOCS-9771/update-component-references-to-include-all-sdks
This PR:
Adds examples for the Clerk components in the @clerk/clerk-expo module
Checklist