-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Sign-in-or-up docs #1772
base: main
Are you sure you want to change the base?
[DO NOT MERGE] Sign-in-or-up docs #1772
Conversation
Hey, here’s your docs preview: https://clerk.com/docs/pr/1772 |
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
…thub.com:clerk/clerk-docs into alexcarpenter/sdki-747-launch-draft-docs-changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for collaborating 😸💖
Thank you! Will hold off on merging until this goes live. I will be sure to keep it up to date with main, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯 🤩
- 👀 I skimmed all the pages linked in the PR description
- ⛏️ For those PR description links, I had to adjust some
signup
vssign-up
differences in the URLs, which is pretty nitpicky so def feel free to ignore. I couldn't find any actual broken links in the docs themselves (... do we have a broken link checker?) - ❓ I found a lil typo-ish bug in the Expo sidebar, I think at some point the
useOauth()
item got dropped and replaced with a duplicatesign-in-or-up
link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you still need to add the custom-sign-up-page routes for all of these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in. a647b31
Important
🔎 Previews:
Account portal:
Next.js:
Expo:
TanStack Start:
Remix:
React Router:
Explanation:
Resolves SDKI-747
We are introducing a combined sign-in-or-up flow that will be the default experience using the
<SignIn />
component. Users will be able to still opt-in to a custom<SignUp />
page by adding a custom sign-up route along with setting theirCLERK_SIGN_UP_URL
.This update will also default Account Portal to using the combined flow, instead of having separate sign-in sign-up pages.
This PR:
<SignIn />
componentChecklist