Skip to content

Make noisy logs debug only #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanbrandenburg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make noisy logs debug only #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions business/definitionService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ class DefinitionService {

_logDefinitionStatus(definition, coordinates) {
if (this._isEmpty(definition)) {
this.logger.info('definition harvest in progress', { coordinates: coordinates.toString() })
this.logger.debug('definition harvest in progress', { coordinates: coordinates.toString() })
} else {
// Log line used for /status page insights
this.logger.info('computed definition available', { coordinates: coordinates.toString() })
Copy link
Collaborator

@qtomlinson qtomlinson Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per the comment online 105, 'computed definition available' is used as a metric for our status page.

this.logger.debug('computed definition available', { coordinates: coordinates.toString() })
}
}

Expand Down
15 changes: 0 additions & 15 deletions business/statusService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ class StatusService {
_getStatusLookup() {
return {
requestcount: this._requestCount,
definitionavailability: this._definitionAvailability,
Copy link
Collaborator

@qtomlinson qtomlinson Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in our ui, see https://dev.clearlydefined.io/status

processedperday: this._processedPerDay,
recentlycrawled: this._recentlyCrawled,
crawlbreakdown: this._crawlbreakdown,
Expand All @@ -57,20 +56,6 @@ class StatusService {
}, {})
}

async _definitionAvailability() {
const data = await requestPromise(
this._serviceQuery(`
traces
| where timestamp > ago(90d)
| where message == "recomputed definition available" or message == "definition not available" or message == "computed definition available"
| summarize count() by message`)
)
return data.tables[0].rows.reduce((result, row) => {
result[row[0]] = row[1]
return result
}, {})
}

async _processedPerDay() {
const data = await requestPromise(
this._crawlerQuery(`
Expand Down