Skip to content

Remove cleanup shared controller in router #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siuying wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove cleanup shared controller in router #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions lib/routable/router.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,18 +178,6 @@ def controller_for_url(url)

if open_options[:shared]
shared_vc_cache[url] = controller
# when controller.viewDidUnload called, remove from cache.
controller.class.class_eval do
define_method(:new_dealloc) do
shared_vc_cache.delete url
end
end
controller.instance_eval do
def viewDidUnload
new_dealloc
super
end
end
end

transition = open_options[:transition]
Expand Down