Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 24, 2025

Pins down the GHC version down to the minor version. As discussed in a PR in clash-cores
(clash-lang/clash-cores#44 (comment)).

Each supported GHC version is now postfixed with a minor version number. However the overlays are not. The last digit of the version number gets stripped when Nix imports an overlay. This way we can have one set of GHC version numbers pin down the right GHC version and import the right overlay.

I nix build .#clash-ghc with all three versions succesfully.

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

This is an automatic copy of pull request #2984 done by [Mergify](https://mergify.com).

Pins down the GHC version down to the minor version. As discussed in a
PR in clash-cores
(clash-lang/clash-cores#44 (comment)).

Each supported GHC version is now postfixed with a minor version number.
However the overlays are not. The last digit of the version number gets
stripped when Nix imports an overlay. This way we can have one set of
GHC version numbers pin down the right GHC version *and* import the
right overlay.

I `nix build .#clash-ghc` with all three versions succesfully.

(cherry picked from commit 762f7f0)

# Conflicts:
#	flake.nix
@mergify mergify bot added the conflicts label Oct 24, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Oct 24, 2025

Cherry-pick of 762f7f0 has failed:

On branch mergify/copy/1.8/pr-2984
Your branch is up to date with 'origin/1.8'.

You are currently cherry-picking commit 762f7f0f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   README.md
	modified:   nix/overlay.nix

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   flake.nix

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@DigitalBrains1 DigitalBrains1 marked this pull request as draft October 24, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants