Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add tooltip to emoji button #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gianniguida
Copy link

  • Use TextEditorButton for the emoji button in the Text Editor toolbar, so that the tooltip is showing when hovering on the button. The tooltip does (now) go away when not hovering on the button.
  • Upgrade JS dependencies

emoji-picker

@clarkwinkelmann
Copy link
Owner

clarkwinkelmann commented Jan 16, 2025

Thanks for the PR. It will take some time before I can review and merge it.

I will likely not merge this code as-is, because I don't like the JSX/TSX syntax and don't use it in any of the clarkwinkelmann-namespaced extensions. If you would like to re-submit the PR with only functional and no syntax changes that would be most appreciated.

@gianniguida
Copy link
Author

No problem! I removed the syntax changes as requested 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants