Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM dev-only dependencies #147

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

Updated NPM dev-only dependencies.

@f1ames
Copy link
Contributor

f1ames commented Nov 23, 2020

Tests breaks completely so it seems it's related to Angular 11. We should probably take a look at #148 soon.

@Dumluregn
Copy link
Collaborator

I can't post a reference as I've already restarted the build for production dependencies, but the log result was that Travis doesn't support Angular 11 yet, so it's possible that it still works. Still, I'll test it locally with Karma.

@Dumluregn
Copy link
Collaborator

Bumping just those deps is indeed causing errors, however if you also apply the changes proposed in #146, everything works fine. That indicates we shouldn't divide bumping those dependencies, so it would be good to perform #151 as soon as possible.

@Dumluregn
Copy link
Collaborator

Dumluregn commented Nov 27, 2020

Changes from this PR are also in #152.

@Dumluregn Dumluregn closed this Nov 27, 2020
@f1ames f1ames deleted the deps-update_master_dev-only branch December 1, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants