feat: add audio ducking settings and level control#626
Closed
mdelrosario92 wants to merge 2 commits intocjpais:mainfrom
Closed
feat: add audio ducking settings and level control#626mdelrosario92 wants to merge 2 commits intocjpais:mainfrom
mdelrosario92 wants to merge 2 commits intocjpais:mainfrom
Conversation
Owner
|
Is this not #547? What makes your approach better? Have you read that existing thread? You also did not provide screenshots or anything else, so I'm less favorable to this PR out of the gate. Nor did you follow the PR template. |
Author
|
Oops, you're right! I'm silly and completely missed that #547 was already covering this. My apologies for the duplication and for missing the PR template - I should have checked existing PRs first. Closing this now to avoid any further confusion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing