-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ListSnapshots RPC #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR 👍
I think it is good overall!
I have made a few comments, please check them out. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM! 👍
@Praveen005 |
This PR implements the
ListSnapshots
RPC method as part of the CSI Driver's Snapshot & Restore functionality. It handle various cases for listing snapshots,Case 1: Fetch by Snapshot ID
Case 2: Fetch by Source Volume ID
Case 3: Fetch All Snapshots
The results are sorted and returned.
Reason: To make the order deterministic