Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refresh shoot creation How-To guide #297

Merged

Conversation

colder-is-better
Copy link
Contributor

@colder-is-better colder-is-better commented Oct 1, 2024

We now support Labels, Taints, and Tolerations, so we update the prose accordingly. Also, we point out that paramaters like flavor, volume size, autoscaler min/max, and max surge have a scope limited to a Worker Group only. While at it, we refresh all screenshots for new/changed UI elements.

@fghaas
Copy link
Contributor

fghaas commented Oct 1, 2024

WARNING -  Doc file 'howto/kubernetes/gardener/create-shoot-cluster.md' contains an absolute link '/howto/kubernetes/gardener/rolling-upgrades', it was left as is. Did you mean 'rolling-upgrades.md'?

Please fix, and also please set up your local work environment as recommended.

@colder-is-better colder-is-better force-pushed the create_gardener_howto_refresh branch from d9cee70 to b1c844e Compare October 1, 2024 13:59
Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have just a couple of tiny nits.

We now support Labels, Taints, and Tolerations, so we
update the prose accordingly. Also, we point out that
paramaters like flavor, volume size, autoscaler min/max,
and max surge have a scope limited to a Worker Group
only. While at it, we refresh all screenshots for
new/changed UI elements.
@colder-is-better colder-is-better force-pushed the create_gardener_howto_refresh branch from b1c844e to efeeca7 Compare October 1, 2024 14:25
@fghaas fghaas merged commit efeeca7 into citynetwork:main Oct 1, 2024
3 checks passed
@colder-is-better colder-is-better deleted the create_gardener_howto_refresh branch December 19, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants