marque and map section #15
Conversation
made the buttons and div responsive
fix : ContextSwitch:
|
@Kaarthik-07 is attempting to deploy a commit to the cittakshashila Team on Vercel. A member of the Team first needs to authorize it. |
MKMukeshkannan
left a comment
MKMukeshkannan
left a comment
There was a problem hiding this comment.
- Kindly remove the package-lock.json file
- Use section instead of div for better code semantics
- Rename images
- Try to stay within tailwindcss and limit yourself from using inline styles and global css
| "tailwindcss": "^3.3.0", | ||
| "typescript": "^5" | ||
| } | ||
| }, |
There was a problem hiding this comment.
- Remove the author, license, repository and main keys
- Kindly rename the images with proper name.
src/components/CardButtonn.tsx
Outdated
| return ( | ||
| <> | ||
|
|
||
| <div className="flex justify-evenly"> |
There was a problem hiding this comment.
- replace div with section of better code semantics
src/components/Marquee.tsx
Outdated
| const Images = [ | ||
| { | ||
| id: 1, | ||
| src :'https://raw.githubusercontent.com/jesvijonathan/Takshashila/master/static/sponsors/Group%20298%20(1).webp', |
There was a problem hiding this comment.
- do not use external images, use images in the repository
|
|
||
| return ( | ||
| <nav className="flex justify-between items-center h-16 fixed z-50 w-full p-8 pt-16 md:p-20"> | ||
| <nav className="flex justify-between items-center h-16 fixed z-50 w-full p-8 pt-16 md:p-20 res"> |
There was a problem hiding this comment.
- try to use responsive breakpoint given in the tailwind, try to avoid writing custom breakpoints
src/components/ToggleButton.tsx
Outdated
|
|
||
| {/* <div className="flex justify-center items-center h-screen"> */} | ||
| <div className="defaultStyle" style={{}}> | ||
| <div className="" style={{margin:'2%'}}> |
There was a problem hiding this comment.
- don't use explicit inline styling, try to stay with tailwind classes
|
** Enhance Responsiveness and Update Marquee Animation** Changes IntroducedThis pull request introduces several updates aimed at improving the application's responsiveness and enhancing visual animations. Here are the key changes:
**Medium Devices -Large Devices: |
3 participants
Marquee and Carosuel done
marquee functions :
hover on stop
hover on opacity reduce
responsive done
Map card button
Functions:
on hover map position changes
Added button for two cards section
Responsive design done
Smooth animation done for both sections
Dependency: to be installed
yarn add react-fast-marquee
yarn add framer-motion