Skip to content

Conversation

@Qotrek
Copy link

@Qotrek Qotrek commented May 3, 2025

In my case, the player who received the warning and was handcuffed couldn't hide it because the handcuff script blocked the control from jumping. :D

@Qotrek Qotrek requested a review from tabarra as a code owner May 3, 2025 09:25
@yorick2002
Copy link
Contributor

yorick2002 commented May 3, 2025

The point of the warning is that it's annoying to the offender 🤷‍♂️ nvm i misread my bad

@tabarra
Copy link
Collaborator

tabarra commented May 3, 2025

Ohh so you are just double checking if the key is pressed, even if it's disabled.
Got it, thanks for the PR, will see if someone can test so I can merge for the next update.

while true do
Wait(100)
if IsControlPressed(dismissKeyGroup, dismissKey) then
if IsControlPressed(dismissKeyGroup, dismissKey) or IsDisabledControlPressed(dismissKeyGroup, dismissKey) then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to call this twice, will still work

Suggested change
if IsControlPressed(dismissKeyGroup, dismissKey) or IsDisabledControlPressed(dismissKeyGroup, dismissKey) then
if IsDisabledControlPressed(dismissKeyGroup, dismissKey) then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants