Skip to content

More action updates - #16126

Open
SandPoot wants to merge 5 commits into
citadel-station:masterfrom
SandPoot:more-action-updates
Open

More action updates#16126
SandPoot wants to merge 5 commits into
citadel-station:masterfrom
SandPoot:more-action-updates

Conversation

@SandPoot

@SandPoot SandPoot commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

About The Pull Request

Title.

Why It's Good For The Game

It's cool.

Changelog

🆑
fix: Inventory checks properly for showing if you can wear something.
fix: Action drop points no longer linger on screen.
refactor: Touched action code a lot.
qol: Item based actions can be granted in specific slots now.
qol: Observers can see players' action buttons.
/:cl:

@SandPoot
SandPoot requested a review from deathride58 as a code owner March 4, 2025 22:52
@@ -0,0 +1,96 @@
// /obj/item signals

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick - for all of the dcs files, it's best to have signals be like this

/// text
#define

or atleast like this
#define ... //! text

this way langserv comments it

not really too important but just as a note

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, my bad, if you could tell i was reorganizing stuff, moving the object/item stuff into its own file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants