Skip to content

[DO NOT MERGE] Harddel unit test - #15948

Open
KrissKr0ss wants to merge 16 commits into
citadel-station:masterfrom
KrissKr0ss:harddel-test
Open

[DO NOT MERGE] Harddel unit test#15948
KrissKr0ss wants to merge 16 commits into
citadel-station:masterfrom
KrissKr0ss:harddel-test

Conversation

@KrissKr0ss

@KrissKr0ss KrissKr0ss commented Jan 22, 2023

Copy link
Copy Markdown
Contributor

About The Pull Request

Ports over tgstation/tgstation#59612

Adds a unit test that runs at the very end of all other tests. It creates and then instantly destroys one of each type path. Some are blacklisted because of various reasons.

This won't catch anywhere near everything, but it'll help a lot with regressions, and catches a lot of runtimes too. The really nasty stuff is things that sleep as a part of initialize, since we don't init, wait, then qdel since it's a lot more prone to error

Oh and I went through and fixed all the errors I could, alongside adding descriptive errors on the stuff that's just gonna runtime in init.

This is gonna cause some unit test failures, but hopefully it'll just catch the simple stuff, which should be easy for people to fix.

Why It's Good For The Game

The Guide

This'll allow us to prevent hard delete regression, and it'll catch a good amount of general errors too since we're guaranteed to hit the init and destroy procs of nearly every typepath, which should help prevent runtime spam from say, spooky material not cleaning up properly or whatever.

Changelog

🆑
code: adds a unit test that looks for harddels
/:cl:

this is the easy part, believe it or not
@KrissKr0ss
KrissKr0ss marked this pull request as draft January 22, 2023 22:21
@Mothblocks

Copy link
Copy Markdown
Contributor

image

image

@KrissKr0ss
KrissKr0ss marked this pull request as ready for review August 19, 2023 00:35

@DeltaFire15 DeltaFire15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing its own added test for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants