Skip to content

Manual Hardsync - #15598

Open
SandPoot wants to merge 24 commits into
citadel-station:masterfrom
SandPoot:hardsync-maybe
Open

Manual Hardsync#15598
SandPoot wants to merge 24 commits into
citadel-station:masterfrom
SandPoot:hardsync-maybe

Conversation

@SandPoot

@SandPoot SandPoot commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

About The Pull Request

Title.

Why It's Good For The Game

Maybe, but it was a pain to make it.
fill the changelogs sometime.

Changelog

🆑
refactor: Completely replaces Citadel's fov system with tg's.
refactor: Completely replaces the old system of underfloor contents with /datum/element/undertile.
refactor: Modifies planes and layers.

add: Added new things
add: Added more things
del: Removed old things
tweak: tweaked a few things
balance: rebalanced something
fix: fixed a few things
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
imageadd: added some icons and images
imagedel: deleted some icons and images
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
wip: still being worked on
experiment: experimental
tgs: has something to do with tgs
expansion: expands on something
qol: quality of life content
/:cl:

@CitadelStationBot CitadelStationBot added Config Update Changes to server configuration options Merge Conflict Pull request is in a conflicted state with base branch SQL Change to database schema/handling labels Apr 24, 2022
@CitadelStationBot CitadelStationBot removed the SQL Change to database schema/handling label Apr 24, 2022
@SandPoot SandPoot changed the title Catwalks, /datum/element/undertile, layer updates Manual Hardsync Apr 24, 2022
@CitadelStationBot CitadelStationBot removed the Merge Conflict Pull request is in a conflicted state with base branch label Apr 24, 2022
@CitadelStationBot CitadelStationBot added the Merge Conflict Pull request is in a conflicted state with base branch label May 17, 2022
@CitadelStationBot CitadelStationBot removed the Merge Conflict Pull request is in a conflicted state with base branch label May 17, 2022
@SandPoot
SandPoot marked this pull request as ready for review May 24, 2022 18:34
@SandPoot
SandPoot requested a review from deathride58 as a code owner May 24, 2022 18:34
@deathride58 deathride58 added the Test Merge Candidate Code is maintainer okayed but requires live testing label May 25, 2022
@CitadelStationBot

Copy link
Copy Markdown
Contributor

Test Merge Deployed

Server Instance

Citadel Main

Revision

Origin: f4dca7c
Pull Request: 2f93401
Server: 32bddde14dcc1468a614854e98f95ea08625de61

Comment

@CitadelStationBot CitadelStationBot removed the Test Merge Candidate Code is maintainer okayed but requires live testing label May 25, 2022
@CitadelStationBot

Copy link
Copy Markdown
Contributor

Test Merge Updated

Server Instance

Citadel Main

Revision

Origin: e577995
Pull Request: eab6300
Server: c71e63533ed6a029ec4f5e26c67c6d06d253df5f

Comment

@CitadelStationBot

Copy link
Copy Markdown
Contributor

Test Merge Removed

@deathride58

deathride58 commented May 25, 2022

Copy link
Copy Markdown
Member

For future investigation:

  • Plastic flap overlays and other objects that previously layered above mobs no longer do so; they need to be moved to GAME_PLANE_UPPER
  • The "Game Preferences" verb causes the lighting planemaster and dropshadows to duplicate every single time you press it
  • Character previews no longer render in game preferences (porting TG's TGUI chargen isn't necessary to resolve this, as they're still using map-based previews)
  • Bot pathing is invisible

CitadelStationBot pushed a commit that referenced this pull request Jun 15, 2022
@SandPoot

SandPoot commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

Yet to solve

  • Weather is not visible, only appears on the plane 1101, something must be hiding it.

@DeltaFire15 DeltaFire15 added Merge Conflict Pull request is in a conflicted state with base branch Stale Pull request is awaiting delayed author response and may be closed labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Config Update Changes to server configuration options Content Expansion Map Edit Mechanic Merge Conflict Pull request is in a conflicted state with base branch Quality of Life Sprites Change to .dmi file Stale Pull request is awaiting delayed author response and may be closed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants