Skip to content

Geoportal refactor isolated #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 70 commits into
base: dev
Choose a base branch
from
Draft

Geoportal refactor isolated #441

wants to merge 70 commits into from

Conversation

@mxfh
Copy link
Contributor

@mxfh mxfh commented Oct 23, 2025 •
edited
Loading

Do not delete !
extract and reuse or use as model

  • cesium style config and setup in cesium core.
  • cesium/leaflet home sync
  • portalContext should not be reused as is MapFrameworkSwitcher handles available Engine registration now.

commons libs are already extracted and merged.

mxfh added 30 commits October 9, 2025 10:33
@mxfh
wip ctx is unstable, use more granularily
c1da126
@mxfh
refactor: memoize geoportal topicmap and improve 2D/3D transitions
a0e14dc 
- Split GeoportalMap into TopicMapComponentWrapper and CesiumMapComponentWrapper
- Separate hash routing logic for Leaflet-like maps (useMapHashRoutingLeafletLike) and Cesium (useMapHashRoutingCesium)
- Extract feature info lifecycle hooks and modal menu logic
- Remove transition state from Redux store to avoid unnecessary rerenders
- Track transition state via ref in MapTypeSwitcher for better performance
- Improve topicmap hooks organization and stability
- Add overlay helper hooks
- Stabilize onChange handlers with refs to prevent rerender triggers
- Handle oblique mode lifecycle via ref
- Clean up topicmap utilities and Leaflet zoom controls
@mxfh
rebase second refactor on top
6d4c777
@mxfh
fix limiter
6642f1a
@mxfh
make 3d post transition animatio cancellable
9187be8
@mxfh
minor
3946361
@mxfh
fix builds and behavior
8ed3517
@mxfh
improve marker cleanup race condition
f7c3e80
@mxfh
fix transition on load, remove unused code
09ec318
@mxfh
test marker models for existence before reuse
e5a6643
@mxfh
improve debug setup for geoportal
b6f57fc
@mxfh
dx/tweak vite config and error logging for geoportal
6a6df0b
@mxfh
feature/handle transition cancellations and make maptypeswitcher more…
17ac95c 
… stable
@mxfh
trigger synthetic map change events on 2d mode changes wip
84d271b
@mxfh
trigger synthetic map change events on 2d mode changes wip cont
217015e
@mxfh
refactor popstate handling
e85d096
@mxfh
fix popstat nav handling
b9baf77
@mxfh
streamline state handling for map changes in geoportal
9a32b23
@mxfh
Merge remote-tracking branch 'origin/dev' into feature/geoportal-refa…
2142bc0 
…ctor
@mxfh
wip
5c1cfd5
@mxfh
wip
494f298
@mxfh
wip needs some way out
6e76052
@mxfh
Merge remote-tracking branch 'origin/dev' into feature/geoportal-refa…
97f20a9 
…ctor
@mxfh
cleanup refactor
e31fb3d
@mxfh
repair and provide hgk and playground with stable snapshots of cesium…
93efd2c 
… engine
@mxfh
specify styling api, finalize cesium engine libs, split cesium lib in…
6664b6d 
…to core and api move oblique mode into cesium engine scope
@mxfh
wip working styling from style configs
cc61578
@mxfh
merge dev into feature/geoportal-refactor
ea7153d
@mxfh
chore/prettier
3d97659
@mxfh
wip improve transitions, fix geoportal app setup
a4bc622
@mxfh mxfh force-pushed the geoportal-refactor-isolated branch from 5c44c0b to 94ecffc Compare October 23, 2025 12:36
@mxfh mxfh force-pushed the geoportal-refactor-isolated branch from ac3abcf to 6e581b3 Compare October 23, 2025 12:57
mxfh added 20 commits October 23, 2025 15:34
@mxfh
fix legacy zoom controls, remove unused tileset component
afb3f95
@mxfh
wip geoportal finalization, split out mapcontrols
49f45b0
@mxfh
rework 2d/3d logic for ui to per engine approach
8696648
@mxfh
fix compass mouse up behavior
6451ad5
@mxfh
improve camera position getters with using world coodinates
35da7f9
@mxfh
improve transitions, move scene and scenestyle handling in scenecompo…
b975127 
…nent, out of context
@mxfh
wip
e645566
@mxfh
wip new portalcontext architecture, topicmap parity
31b1921
@mxfh
wip fix builds
619eab4
@mxfh
wip fix all builds
5c42d75
@mxfh
wip simplify portalContext
8e7cffb
@mxfh
wip config validation for portalcontext
aeb88d5
@mxfh
wip all build, geoportal refactor
a54ea79
@mxfh
wip update geoportal/topicmap to new portalcontext arch
05dca92
@mxfh
wip fix topicmap gazateer selection handling
2cae2de
@mxfh
wip fix topicmap gazateer selection reselection recentering
bf4e426
@mxfh
fix cesium camera init from portal
f000cad
@mxfh
wip transition scale
b8489ba
@mxfh
wip transition scale
b5704b8
@mxfh
wip style sync url
373219c
@mxfh mxfh mentioned this pull request Nov 5, 2025
Merged
3 tasks
@mxfh mxfh added app:geoportal app geoportal lib:cesium Cesium Library pr:reference keep pr for reference as draft, do not delete dx:refactor labels Nov 11, 2025
This was referenced Nov 11, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

app:geoportal app geoportal dx:refactor lib:cesium Cesium Library pr:reference keep pr for reference as draft, do not delete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mxfh