-
Notifications
You must be signed in to change notification settings - Fork 1
dx/migrate-nx-21 #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
dx/migrate-nx-21 #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the workspace to NX 21, removes legacy test configurations, and standardizes Vite/project settings across services, libraries, and playgrounds.
- Upgrade Nx and related plugins to version 21 and update package.json dependencies
- Remove standalone
tsconfig.spec.json,jest.config.ts, and legacy targets in service and libraryproject.json - Migrate all Vite configs to the inferred NX pattern and standardize quotes,
outDir/outputs, and plugin settings
Reviewed Changes
Copilot reviewed 239 out of 243 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.base.json | Added new path aliases for Wuppertal collab modules |
| services/rasterfari-tileserver-wms-companion/tsconfig.spec.json | Deleted spec config; tests no longer referenced |
| package.json | Bumped version and upgraded NX, Storybook, Vitest |
| nx.json | Removed legacy Jest targets; added NX plugin configs |
| playgrounds/vector/vite.config.ts | Converted to inferred pattern; unused options var |
Comments suppressed due to low confidence (1)
| const configValues = { default: {}, development: {}, production: {} }; | ||
|
|
||
| // Determine the correct configValue to use based on the configuration | ||
| const nxConfiguration = process.env.NX_TASK_TARGET_CONFIGURATION ?? "default"; | ||
|
|
||
| const options = { | ||
| ...configValues.default, | ||
| ...(configValues[nxConfiguration] ?? {}), | ||
| }; | ||
|
|
Copilot
AI
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configValues and options variables are defined but never used in defineConfig. Consider removing them or merging options into the config object to avoid dead code.
| const configValues = { default: {}, development: {}, production: {} }; | |
| // Determine the correct configValue to use based on the configuration | |
| const nxConfiguration = process.env.NX_TASK_TARGET_CONFIGURATION ?? "default"; | |
| const options = { | |
| ...configValues.default, | |
| ...(configValues[nxConfiguration] ?? {}), | |
| }; | |
| // Removed unused configValues and options variables. |
squashed version of dx/nx-migrate-21
#327
for easier rebase.
consider splitting out migration to infered projects into new PR or postpone that part.
for that plugins in nx.json and changes to project.json and tooling files would need to be reverted.