Skip to content

Conversation

@mxfh
Copy link
Contributor

@mxfh mxfh commented Jun 24, 2025

squashed version of dx/nx-migrate-21
#327
for easier rebase.

  • delete apps/test-vite-canonical/ before merging, it's there for comparing code generated by nx generators with installed nx version as reference
  • delete all migration logs
  • validate build and other relevant scripts

consider splitting out migration to infered projects into new PR or postpone that part.
for that plugins in nx.json and changes to project.json and tooling files would need to be reverted.

@mxfh mxfh changed the title dx/nx-migrate-21 dx/migrate-nx-21 Jun 24, 2025
@mxfh mxfh requested a review from Copilot June 24, 2025 18:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the workspace to NX 21, removes legacy test configurations, and standardizes Vite/project settings across services, libraries, and playgrounds.

  • Upgrade Nx and related plugins to version 21 and update package.json dependencies
  • Remove standalone tsconfig.spec.json, jest.config.ts, and legacy targets in service and library project.json
  • Migrate all Vite configs to the inferred NX pattern and standardize quotes, outDir/outputs, and plugin settings

Reviewed Changes

Copilot reviewed 239 out of 243 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsconfig.base.json Added new path aliases for Wuppertal collab modules
services/rasterfari-tileserver-wms-companion/tsconfig.spec.json Deleted spec config; tests no longer referenced
package.json Bumped version and upgraded NX, Storybook, Vitest
nx.json Removed legacy Jest targets; added NX plugin configs
playgrounds/vector/vite.config.ts Converted to inferred pattern; unused options var
Comments suppressed due to low confidence (1)

Comment on lines +7 to 16
const configValues = { default: {}, development: {}, production: {} };

// Determine the correct configValue to use based on the configuration
const nxConfiguration = process.env.NX_TASK_TARGET_CONFIGURATION ?? "default";

const options = {
...configValues.default,
...(configValues[nxConfiguration] ?? {}),
};

Copy link

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configValues and options variables are defined but never used in defineConfig. Consider removing them or merging options into the config object to avoid dead code.

Suggested change
const configValues = { default: {}, development: {}, production: {} };
// Determine the correct configValue to use based on the configuration
const nxConfiguration = process.env.NX_TASK_TARGET_CONFIGURATION ?? "default";
const options = {
...configValues.default,
...(configValues[nxConfiguration] ?? {}),
};
// Removed unused configValues and options variables.

Copilot uses AI. Check for mistakes.
@mxfh mxfh marked this pull request as draft June 24, 2025 18:41
@mxfh mxfh force-pushed the dx/migrate-nx-21 branch from 11820c4 to c864d23 Compare June 25, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants