Add support for prepared statements #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-circuithub
force-pushed
the
prepared
branch
2 times, most recently
from
b35c498 to
da75d2b
Compare
TeofilC
reviewed
Apr 28, 2025
Contributor
TeofilC
left a comment
TeofilC
left a comment
There was a problem hiding this comment.
I had a quick glance through
michaelpj
reviewed
Apr 28, 2025
| format. For large amounts of data this can be significantly more efficient | ||
| than embedding the values directly in the statement with 'Rel8.lit'. | ||
| -} | ||
| prepared :: forall a b i o. |
There was a problem hiding this comment.
This seeems more like parameterized - there's nothing that requires the statement-function you pass in to be calling a prepared statement, right?
Contributor
Author
There was a problem hiding this comment.
I'm confused about what you mean by "calling a prepared statement". The True here makes the statement preparable.
shane-circuithub
force-pushed
the
prepared
branch
from
6ef778d to
fba8172
Compare
Contributor
|
Is this ready to be merged @shane-circuithub ? |
This requires the introduction of a new `Encoder` type with three members: `binary`, which is the Hasql binary encoder, `text` which encodes a type in PostgreSQL's text format (needed for nested arrays) and `quote`, which does the thing that the function we previously called `encode` does (i.e., `a -> Opaleye.PrimExpr`). This will break any downstream code that uses a completely custom `DBType` implementation, but anything that uses `ReadShow`, `Enum`, `Composite`, `JSONBEncoded` or `parseTypeInformation` will continue working as before (which should cover all common cases). I dropped support for `network-ip` instead of trying to figure out how to write binary and text encoders for it. We still support `iproute`.
shane-circuithub
force-pushed
the
prepared
branch
from
fba8172 to
4a8fff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the introduction of a new
Encodertype with three members:binary, which is the Hasql binary encoder,textwhich encodes a type in PostgreSQL's text format (needed for nested arrays) andquote, which does the thing that the function we previously calledencodedoes (i.e.,a -> Opaleye.PrimExpr).This will break any downstream code that uses a completely custom
DBTypeimplementation, but anything that usesReadShow,Enum,Composite,JSONBEncodedorparseTypeInformationwill continue working as before (which should cover all common cases).I dropped support for
network-ipinstead of trying to figure out how to write binary and text encoders for it. We still supportiproute.