Skip to content

Aggregate.hs: Missing f in haddock #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TeofilC merged 2 commits into from
May 9, 2025
Merged

Aggregate.hs: Missing f in haddock #368

TeofilC merged 2 commits into from
May 9, 2025

Conversation

@JackKelly-Bellroy
Copy link
Contributor

@JackKelly-Bellroy JackKelly-Bellroy commented Apr 26, 2025

No description provided.

@JackKelly-Bellroy
Copy link
Contributor Author

JackKelly-Bellroy commented Apr 26, 2025

There's something else up in this example, because it calls aggregate but groupByOn returns an Aggregator1. I'm not sure if using aggregator1 in the example is sufficient, so I didn't put it in.

@TeofilC TeofilC self-requested a review May 8, 2025 11:55
TeofilC
TeofilC approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@TeofilC TeofilC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@TeofilC TeofilC enabled auto-merge (squash) May 9, 2025 09:52
@TeofilC TeofilC merged commit 5f77751 into circuithub:master May 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TeofilC TeofilC TeofilC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JackKelly-Bellroy @TeofilC